Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

async is a keyword on 3.7 #47

Merged
merged 1 commit into from
Aug 8, 2018
Merged

async is a keyword on 3.7 #47

merged 1 commit into from
Aug 8, 2018

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jun 28, 2018

Fixes #44

@ciscorn
Copy link
Contributor

ciscorn commented Jul 9, 2018

@hroncok It should be something like:

ensure_future = getattr(asyncio, 'ensure_future', None) or getattr(asyncio, 'async')

otherwise the following error occurs on Python 3.7:

AttributeError: module 'asyncio' has no attribute 'async'

@0bsearch
Copy link

0bsearch commented Aug 8, 2018

I propose to drop None in last getattr, to make it fail eventually if neither async/ensure is available.

@fxdgear fxdgear merged commit 7c5adac into elastic:master Aug 8, 2018
@hroncok hroncok deleted the patch-1 branch January 14, 2019 20:10
jvcop added a commit to jvcop/elasticsearch-py-async that referenced this pull request Jan 15, 2019
This has previously been fixed for version 6 in elastic#47.
fxdgear pushed a commit that referenced this pull request Jan 16, 2019
This has previously been fixed for version 6 in #47.
pquentin pushed a commit to clustree/elasticsearch-py-async that referenced this pull request Feb 4, 2021
pquentin pushed a commit to clustree/elasticsearch-py-async that referenced this pull request Feb 4, 2021
pquentin pushed a commit to clustree/elasticsearch-py-async that referenced this pull request Feb 4, 2021
pquentin pushed a commit to clustree/elasticsearch-py-async that referenced this pull request Feb 4, 2021
pquentin pushed a commit to clustree/elasticsearch-py-async that referenced this pull request Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants