This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Replace aiohttp.Timeout with async_timeout.timeout #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ciscorn thanks. was about to issue a similar PR, but looks like it's being handled. |
|
Hey @honzakral, could you merge this one, please? |
|
I'd really like to merge this as well - I'd prefer to avoid having to fork this repo. |
ciscorn
changed the title
pquentin
pushed a commit
to clustree/elasticsearch-py-async
that referenced
this pull request
Feb 4, 2021
pquentin
pushed a commit
to clustree/elasticsearch-py-async
that referenced
this pull request
Feb 4, 2021
pquentin
pushed a commit
to clustree/elasticsearch-py-async
that referenced
this pull request
Feb 4, 2021
pquentin
pushed a commit
to clustree/elasticsearch-py-async
that referenced
this pull request
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiohttp 3.0 dropped
aiohttp.Timeout(which had been just an alias ofasync_timeout.timeout), so we now need to useasync_timeout.timeoutdirectly.closes #37