Update TargetFrameworks

[gpetrou]

Resolves #8050.

[cla-checker-service]

💚 CLA has been signed

[gpetrou]

I used nuget restore -ForceEvaluate to update the packages.lock.json files.

[flobernd]

Seems like the "Unified Release / Assemble" workflow is failing because of the Docker container using the wrong .NET SDK version.

[flobernd]

Thanks for updating!

I think there is/was a bug in the way we pass the argument in the Docker commandline:

elasticsearch-net/.ci/make.sh

Line 136 in 4a6b9e8

--env "DOTNET_VERSION" \

[flobernd]

Thanks again for updating. Seems like we are going down a rabbithole... The newer SDKs seem to use different temp paths which causes building the docker image to fail.

[gpetrou]

The newer SDKs seem to use different temp paths which causes building the docker image to fail.

I think we need to append the user name at the end of the NuGetScrarch folder name. If I understand correctly, this should be user.
https://learn.microsoft.com/en-us/nuget/consume-packages/managing-the-global-packages-and-cache-folders

[flobernd]

Maybe we can just set the NUGET_SCRATCH environment variable to /tmp/NuGetScratch to restore the old behavior. Inside the Docker container we only have a single active user anyways.

And we should probably fix the Docker build in a proper way by adding:

--build-arg DOTNET_VERSION="$DOTNET_VERSION"

here:

elasticsearch-net/.ci/make.sh

Line 125 in 4a6b9e8

[flobernd]

Thanks again for updating!

Seems like the container contains a newer version of Git and we now have to disable the repository owner checks.. Adding:

RUN git config --global --add safe.directory '*'

before:

elasticsearch-net/.ci/DockerFile

Line 45 in 4a6b9e8

RUN git rev-parse HEAD .

should probably do the trick.

[flobernd]

Ok, so regenerating the lockfiles for scripts.fs should be the only thing left to do.

[flobernd]

Looking good now! Thanks again for the PR and the updates. I'll merge on Monday and include the changes in the next patch release.

[flobernd]

LGTM! Thank you 🙂

[landlord-matt]

@flobernd Both .NET 7 and .NET 8 focused on JSON serialisation performance. Did you notice any difference from this .NET 6 version?

Will the patch release also target Elasticsearch 8.6? When do you expect the patch release?

[flobernd]

@landlord-matt I don't think there will be any noticeable performance benefits as most of the optimizations are related to the codegen features which we don't use yet (they require code changes).

The patch will only target 8.12, but you should be able to update your 8.6 library to 8.12.1 when it's released. I think we had no major breaking changes since then.

A patch release will happen until end of March.