Refactor client overloads #7880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
approved these changes
Aug 9, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Simplify overloads and avoid repeated code * Ensure we pass cancellation token to transport
flobernd
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Simplify overloads and avoid repeated code * Ensure we pass cancellation token to transport Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a chunk of repeated code which was hard to keep in sync. As these are all internal methods, I've restructured the overloads and removed a redundant one. Currently, we don't use the
forceConfigurationoverload, which we should probably review and either remove those overloads or reintroduce NEST force config behaviour.This also fixes a bug where we don't always pass the cancellation token on transport calls making it impossible for some requests to be cooperatively cancelled.