Fix code-gen for single or many types. #7244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
This was referenced Feb 27, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Feb 27, 2023
* Add test for GetIndex response deserialization * Add missing implementation for union converter * Regenerate after code generator improvements JSON serializer attributes are now included on a single line after some recent codegenerator changes to support conditional attributes. * Formatting updates after updating Roslyn packages * Add number handling options to serializers * After fixed codegen for DynamicTemplate * Remove special handling for sort converter in generator Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7221.
Fixes #7234.
Fixes #7240.
Introduces a converter for single or many types allowing them to be code generated correctly. Some unions are simplified as single or many collections rather than a union of , ICollection.
It also includes a fix to support numbers as strings in JSON responses from the server.