Fix resolvable dictionary properties #7076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These ensure keys are santised during lookups so that items can be found correctly using inferred values.
stevejgordon
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency
This was referenced Dec 6, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency
stevejgordon
added a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 6, 2022
* Prefer IReadOnlyDictionary on read only (response) types * Introduce readonly dictionary converters for Field and IndexName These ensure keys are santised during lookups so that items can be found correctly using inferred values. * Prefer IDictionary for properties on writable types * Update tests * Fix BOM * Cleanup IUrlParameter types for consistency Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7075.