Skip to content

[Backport 8.1] Fix typos in 8.0.1 release notes #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[Backport 8.1] Fix typos in 8.0.1 release notes #7042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/release-notes/release-notes-8.0.1.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,28 +22,28 @@ This release includes the following breaking changes:

The `Core.MSearchTemplate.RequestItem` type has been renamed to
`Core.MSearchTemplate.SearchTemplateRequestItem`. It no longer derives from the
`Union<T1, T2>` type. It has been manually designed to support serialisation to
`Union<T1, T2>` type. It has been manually designed to support serialization to
NDJSON, as required by the MSearchTemplate endpoint.

The `MultiSearchTemplateRequest.SearchTemplates` property has been updated to
use this newly defined type.

This breaking change has been included in this patch release due to the
original code-generated type not functioning correctly and therefore we have
original code-generated type functioning incorrectly, and therefore, we have
determined that this should ship ASAP.

[discrete]
==== MultiSearch type changes

The `Core.MSearch.SearchRequestItem` type has been sealed for consistency with
the design choices in the rest of the client. While technically breaking, we
have decided that this should be included in this release before any potential
the design choices of the rest of the client. While technically breaking, we
have decided that this should be included in this release before any potentially
derived types may exist in consuming applications.

[discrete]
==== Sealing union types

Code-generated types derived from `Union<T1, T2>` where incorrectly unsealed.
Code-generated types derived from `Union<T1, T2>` were incorrectly unsealed.
While technically breaking, we have decided that these should be sealed in this
patch release before any potential derived types may exist in consuming
applications. Sealing types by default aligns with our broader design choices
Expand Down