Fix MultiSearchTemplateRequest body #7008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Manual type implements IStreamSerializable to support NDJSON. - Add serialization test
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete
This was referenced Nov 24, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete
stevejgordon
added a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Nov 24, 2022
* Manually define the RequestItem for MultiSearchTemplateRequests - Manual type implements IStreamSerializable to support NDJSON. - Add serialization test * Update integration workflow stack version * Add release notes * Make headings discrete Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7006.
The code generator was correctly generating a Union type based on the specification but was not handling the MIME type for this request and, as a result, did not implement
IStreamSerializableto produce the NDJSON body. This PR removes the code-generated type and adds a new manual type which aligns with theSearchRequestItemforMSearch. The type name was also changed to be more descriptive.