Skip to content

Remove use of similarity and boost from number mappings #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Remove use of similarity and boost from number mappings #4987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions tests/Tests/Mapping/Types/Core/Number/NumberPropertyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@ public NumberPropertyTests(WritableCluster cluster, EndpointUsage usage) : base(
{
type = "integer",
doc_values = true,
similarity = "BM25",
store = true,
index = false,
boost = 1.5,
null_value = 0.0,
ignore_malformed = true,
coerce = true
Expand All @@ -38,10 +36,8 @@ public NumberPropertyTests(WritableCluster cluster, EndpointUsage usage) : base(
.Name(p => p.NumberOfCommits)
.Type(NumberType.Integer)
.DocValues()
.Similarity("BM25")
.Store()
.Index(false)
.Boost(1.5)
.NullValue(0.0)
.IgnoreMalformed()
.Coerce()
Expand All @@ -54,10 +50,8 @@ public NumberPropertyTests(WritableCluster cluster, EndpointUsage usage) : base(
"numberOfCommits", new NumberProperty(NumberType.Integer)
{
DocValues = true,
Similarity = "BM25",
Store = true,
Index = false,
Boost = 1.5,
NullValue = 0.0,
IgnoreMalformed = true,
Coerce = true
Expand All @@ -79,10 +73,8 @@ public ScaledFloatNumberPropertyTests(WritableCluster cluster, EndpointUsage usa
type = "scaled_float",
scaling_factor = 10.0,
doc_values = true,
similarity = "BM25",
store = true,
index = false,
boost = 1.5,
null_value = 0.0,
ignore_malformed = true,
coerce = true
Expand All @@ -96,10 +88,8 @@ public ScaledFloatNumberPropertyTests(WritableCluster cluster, EndpointUsage usa
.Type(NumberType.ScaledFloat)
.ScalingFactor(10)
.DocValues()
.Similarity("BM25")
.Store()
.Index(false)
.Boost(1.5)
.NullValue(0.0)
.IgnoreMalformed()
.Coerce()
Expand All @@ -113,10 +103,8 @@ public ScaledFloatNumberPropertyTests(WritableCluster cluster, EndpointUsage usa
{
ScalingFactor = 10,
DocValues = true,
Similarity = "BM25",
Store = true,
Index = false,
Boost = 1.5,
NullValue = 0.0,
IgnoreMalformed = true,
Coerce = true
Expand Down