Adds more write overloads to Utf8Json #4209
Conversation
Either memory stream or to serialize on the writer. This consolidates and funnels places that need to write bytes/streams/objects directly
src/Nest/CommonAbstractions/SerializationBehavior/JsonFormatters/SourceFormatter.cs
Outdated
Show resolved
Hide resolved
|
|
||
| var bodyBytes = bodySerializer.SerializeToBytes(body, memoryStreamFactory, SerializationFormatting.None); | ||
| writer.WriteRaw(bodyBytes); | ||
| SourceWriter.Serialize(ref writer, body, formatterResolver); |
There was a problem hiding this comment.
This looks like a behavioural change?
There was a problem hiding this comment.
Because SerializationFormatting.None is not specified explicitly?
There was a problem hiding this comment.
The behavioural change looks like the SourceWriter is now always used.
Before, the requestResponseSerializer was used when the operation was an update or the body was an ILazyDocument
There was a problem hiding this comment.
Ahh you are right, will address!
| @@ -32,12 +32,16 @@ public SerializerRegistrationInformation(Type type, string purpose) | |||
| public override string ToString() => _stringRepresentation; | |||
| } | |||
|
|
|||
| //TODO this no longer needs to be IInternalSerializerWithFormatter | |||
There was a problem hiding this comment.
Does DiagnosticsSerializerProxy still need to implement IInternalSerializerWithFormatter?
There was a problem hiding this comment.
Remove it instead since its internal
|
Closing in favor of: #4313 Addressed remaining feedback there as well. |
Either memory stream or to serialize on the writer.
This consolidates and funnels places that need to write bytes/streams/objects directly.
Isolated from #4172 and #4191 which both grew to be too big to review