-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adds versioned benchmarking #4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using BenchmarkDotNet.Attributes; | ||
using Elasticsearch.Net; | ||
using Nest; | ||
using Tests.Benchmarking.Framework; | ||
using Tests.Core.Client; | ||
using Tests.Domain; | ||
|
||
namespace Tests.Benchmarking | ||
{ | ||
[BenchmarkConfig(5)] | ||
public class BulkBenchmarkTests | ||
{ | ||
private static readonly IList<Project> Projects = Project.Generator.Clone().Generate(10000); | ||
private static readonly byte[] Response = TestClient.DefaultInMemoryClient.ConnectionSettings.RequestResponseSerializer.SerializeToBytes(ReturnBulkResponse(Projects)); | ||
|
||
private static readonly IElasticClient Client = | ||
new ElasticClient(new ConnectionSettings(new InMemoryConnection(Response, 200, null, null)) | ||
.DefaultIndex("index") | ||
.EnableHttpCompression(false) | ||
); | ||
|
||
//TODO can uncomment when https://github.com/elastic/elasticsearch-net/pull/4202 lands | ||
// private static readonly IElasticClient ClientNoRecyclableMemory = | ||
// new ElasticClient(new ConnectionSettings(new InMemoryConnection(Response, 200, null, null)) | ||
// .DefaultIndex("index") | ||
// .EnableHttpCompression(false) | ||
// .MemoryStreamFactory(MemoryStreamFactory.Default) | ||
// ); | ||
|
||
private static readonly Nest7.IElasticClient ClientV7 = | ||
new Nest7.ElasticClient(new Nest7.ConnectionSettings( | ||
new Elasticsearch.Net7.InMemoryConnection(Response, 200, null, null)) | ||
.DefaultIndex("index") | ||
.EnableHttpCompression(false) | ||
); | ||
|
||
[GlobalSetup] | ||
public void Setup() { } | ||
|
||
[Benchmark(Description = "PR")] | ||
public BulkResponse NestUpdatedBulk() => Client.Bulk(b => b.IndexMany(Projects)); | ||
|
||
// [Benchmark(Description = "PR no recyclable")] | ||
// public BulkResponse NoRecyclableMemory() => ClientNoRecyclableMemory.Bulk(b => b.IndexMany(Projects)); | ||
|
||
[Benchmark(Description = "7.x")] | ||
public Nest7.BulkResponse NestCurrentBulk() => ClientV7.Bulk(b => b.IndexMany(Projects)); | ||
|
||
private static object BulkItemResponse(Project project) => new | ||
{ | ||
index = new | ||
{ | ||
_index = "nest-52cfd7aa", | ||
_id = project.Name, | ||
_version = 1, | ||
_shards = new | ||
{ | ||
total = 2, | ||
successful = 1, | ||
failed = 0 | ||
}, | ||
created = true, | ||
status = 201 | ||
} | ||
}; | ||
|
||
private static object ReturnBulkResponse(IList<Project> projects) => new | ||
{ | ||
took = 276, | ||
errors = false, | ||
items = projects | ||
.Select(p => BulkItemResponse(p)) | ||
.ToArray() | ||
}; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.