Structural equals for infer and IUrlParameter types #3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebrain
approved these changes
Mar 19, 2018
| @@ -193,6 +200,16 @@ internal static bool IsNullOrEmpty(this string value) | |||
| { | |||
| return string.IsNullOrWhiteSpace(value); | |||
| } | |||
| internal static bool IsNullOrEmptyCommaSeparatedList(this string value, out string[] split) | |||
There was a problem hiding this comment.
Use a .All(...) LINQ extension? might save initialising the array.
There was a problem hiding this comment.
...PEBKAC, just noticed the out parameter!
| } | ||
|
|
||
| public static IndexName From<T>() => typeof(T); | ||
| public static IndexName From<T>(string clusterName) => From(typeof(T), clusterName); | ||
| private static IndexName From(Type t, string clusterName) => new IndexName(t, clusterName); | ||
| // TODO private? |
There was a problem hiding this comment.
left it in there to tackle at a later stage (not related to commit).
|
Yeah this stuff should come baked cough |
… and not a referential Equals() move equality test folder one level down into Inferrence Trim() is bad on singular types, removed triming from them as it only hides bugs. Moved the trim to plural type parsing of multi valued strings made sure implicit conversion from null/empty string/empty comma separated string all behave the same (return null) for IUrlParameters and Infer types Made sure null flows through all the Equals implementations and fixed existing tests that failed due to the updated implementation
Mpdreamz
force-pushed
the
fix/op-overload
branch
from
d2d527c to
ea930b3
Compare
|
Amended to not take |
Mpdreamz
added a commit
that referenced
this pull request
Mar 19, 2018
* All IUrlParameter and infer types now implement a structural Equals() and not a referential Equals() move equality test folder one level down into Inferrence Trim() is bad on singular types, removed triming from them as it only hides bugs. Moved the trim to plural type parsing of multi valued strings made sure implicit conversion from null/empty string/empty comma separated string all behave the same (return null) for IUrlParameters and Infer types Made sure null flows through all the Equals implementations and fixed existing tests that failed due to the updated implementation * boost should not be part of field equality afterall, (current behaviour)
Merged
IIRC, it was to do with field expression caching. If memory serves, the original expression overload did not accept a boost in the early 2.x days, and was added later. |
codebrain
pushed a commit
that referenced
this pull request
Apr 13, 2018
* Structural equals for infer and IUrlParameter types (#3126) * All IUrlParameter and infer types now implement a structural Equals() and not a referential Equals() move equality test folder one level down into Inferrence Trim() is bad on singular types, removed triming from them as it only hides bugs. Moved the trim to plural type parsing of multi valued strings made sure implicit conversion from null/empty string/empty comma separated string all behave the same (return null) for IUrlParameters and Infer types Made sure null flows through all the Equals implementations and fixed existing tests that failed due to the updated implementation * boost should not be part of field equality afterall, (current behaviour) * undo private EqualsString on RelationName, already public in 6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
IUrlParameterandInfertypes now implement a structuralEquals()and not a referentialEquals()IEquatable<>Fieldnow takes boost value into account, this was previously explicitly documented as desired behaviour but I can remember why this was the case, @russcam any ideas?