Skip to content

Refactor datatype mappings #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
russcam opened this issue Mar 21, 2018 · 2 comments
Closed

Refactor datatype mappings #3145

russcam opened this issue Mar 21, 2018 · 2 comments
Labels
Breaking

Comments

@russcam
Copy link
Contributor

russcam commented Mar 21, 2018

Relates #3138

Within mappings, There are some options exposed in base types that are not valid for the inherited types e,g. ObjectProperty does not support Store, but inherits it from CorePropertyBase.

Revisit the inheritance structure to address supported options for each type.
@russcam russcam mentioned this issue Mar 21, 2018
Closed
@codebrain codebrain added v8.0.0 and removed v7.0.0 labels Jun 25, 2019
@russcam
Copy link
Contributor Author

russcam commented Jul 21, 2020

Additional example

  • BinaryProperty and BooleanProperty should not have Similarity

russcam added a commit that referenced this issue Jul 27, 2020
@russcam
Remove similarity from Date property integration tests
65c2892 
This commit removes the Similarity property usage from the
Date and DateNanos property integration tests.

Similarity is not a valid property and should be
removed as part of #3145
@russcam russcam mentioned this issue Jul 27, 2020
Merged
russcam added a commit that referenced this issue Jul 27, 2020
@russcam
Remove similarity from Date property integration tests (#4877)
4d6b0f3 
This commit removes the Similarity property usage from the
Date and DateNanos property integration tests.

Similarity is not a valid property and should be
removed as part of #3145
github-actions bot pushed a commit that referenced this issue Jul 27, 2020
@russcam @github-actions
Remove similarity from Date property integration tests (#4877)
3da667b 
This commit removes the Similarity property usage from the
Date and DateNanos property integration tests.

Similarity is not a valid property and should be
removed as part of #3145
github-actions bot pushed a commit that referenced this issue Jul 27, 2020
@russcam @github-actions
Remove similarity from Date property integration tests (#4877)
0acb600 
This commit removes the Similarity property usage from the
Date and DateNanos property integration tests.

Similarity is not a valid property and should be
removed as part of #3145
russcam added a commit that referenced this issue Jul 27, 2020
@github-actions @russcam
Remove similarity from Date property integration tests (#4877) (#4879)
210a802 
This commit removes the Similarity property usage from the
Date and DateNanos property integration tests.

Similarity is not a valid property and should be
removed as part of #3145

Co-authored-by: Russ Cam <[email protected]>
russcam added a commit that referenced this issue Jul 27, 2020
@github-actions @russcam
Remove similarity from Date property integration tests (#4877) (#4878)
af936de 
This commit removes the Similarity property usage from the
Date and DateNanos property integration tests.

Similarity is not a valid property and should be
removed as part of #3145

Co-authored-by: Russ Cam <[email protected]>
@russcam russcam mentioned this issue Aug 17, 2020
Closed
russcam added a commit that referenced this issue Aug 18, 2020
@russcam
Remove use of similarity in KeywordProperty tests
d6e027c 
This commit removes the use of similarity in
KeywordProperty tests as it is causing
integration test failures on CI.

Upstream changes in Elasticsearch are being made to
mappings which should be addressed in the client
mappings as part of #3145.

(cherry picked from commit 5062883)
russcam added a commit that referenced this issue Aug 18, 2020
@russcam
Remove use of similarity in KeywordProperty tests
5062883 
This commit removes the use of similarity in
KeywordProperty tests as it is causing
integration test failures on CI.

Upstream changes in Elasticsearch are being made to
mappings which should be addressed in the client
mappings as part of #3145.
russcam added a commit that referenced this issue Aug 18, 2020
@russcam
Remove use of similarity in KeywordProperty tests
54ddce9 
This commit removes the use of similarity in
KeywordProperty tests as it is causing
integration test failures on CI.

Upstream changes in Elasticsearch are being made to
mappings which should be addressed in the client
mappings as part of #3145.

(cherry picked from commit 5062883)
russcam added a commit that referenced this issue Aug 25, 2020
@russcam
Remove use of similarity and boost from number mappings
0fa6516 
This commit removes use of fields that now cause a
400 response from Elasticsearch.
These fields will be refactored as part of #3145
This was referenced Aug 25, 2020
Merged
Closed
Mpdreamz pushed a commit that referenced this issue Aug 26, 2020
@russcam
Remove use of similarity and boost from number mappings (#4987)
af5b05d 
This commit removes use of fields that now cause a
400 response from Elasticsearch.
These fields will be refactored as part of #3145
@russcam russcam mentioned this issue Dec 16, 2020
Closed
@stevejgordon
Copy link
Contributor

Closing due to age/inactivity. Will be tackled within code-generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codebrain @russcam @stevejgordon