Skip to content

Add additional sort options for Top Hits aggregation #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
russcam opened this issue Nov 23, 2017 · 0 comments
Closed

Add additional sort options for Top Hits aggregation #2913

russcam opened this issue Nov 23, 2017 · 0 comments

Comments

@russcam
Copy link
Contributor

russcam commented Nov 23, 2017

From Stack Overflow

Top Hits aggregation sort is missing several sort options, including script sorting.
russcam added a commit that referenced this issue Dec 19, 2017
@russcam
Add additional sort options to Top Hits Aggregation
5a1bc45 
Top Hits Aggregation fluent lambda syntax constrains sort options to field sorting, even though ITopHitsAggregation can accept any implementation of ISort. This commit deprecates the current fluent Sort implementation in favour of an implementation that allow multiple sort options besides field sorting, and assigns the resulting collection of sort options to IList<ISort>.

Update TopHitsAggregation usage test to call the new Sort method.

Fixes #2913
@russcam russcam mentioned this issue Dec 19, 2017
Merged
russcam added a commit that referenced this issue Dec 21, 2017
@russcam
Add additional sort options to Top Hits Aggregation (#2968)
826ca5e 
* Add additional sort options to Top Hits Aggregation

Top Hits Aggregation fluent lambda syntax constrains sort options to field sorting, even though ITopHitsAggregation can accept any implementation of ISort. This commit deprecates the current fluent Sort implementation in favour of an implementation that allow multiple sort options besides field sorting, and assigns the resulting collection of sort options to IList<ISort>.

Update TopHitsAggregation usage test to call the new Sort method.

Fixes #2913

* Remove superfluous using directive
russcam added a commit that referenced this issue Dec 21, 2017
@russcam
Add additional sort options to Top Hits Aggregation (#2968)
eba9fd9 
* Add additional sort options to Top Hits Aggregation

Top Hits Aggregation fluent lambda syntax constrains sort options to field sorting, even though ITopHitsAggregation can accept any implementation of ISort. This commit deprecates the current fluent Sort implementation in favour of an implementation that allow multiple sort options besides field sorting, and assigns the resulting collection of sort options to IList<ISort>.

Update TopHitsAggregation usage test to call the new Sort method.

Fixes #2913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@russcam