Skip to content

Add phrase_limit for FVH highlighting #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
russcam opened this issue Sep 12, 2017 · 3 comments
Closed

Add phrase_limit for FVH highlighting #2851

russcam opened this issue Sep 12, 2017 · 3 comments

Comments

@russcam
Copy link
Contributor

russcam commented Sep 12, 2017

from stackoverflow

Fast Vector Highlighter should have phrase_limit
@bkowald
Copy link

bkowald commented Dec 5, 2017

Hi Russ, so does this mean that this is added in Elastic version 5.5.5?

@russcam
Copy link
Contributor Author

russcam commented Dec 15, 2017

@bkowald This hasn't been addressed yet. Looking at now. Apologies that it has taken so long to look at this

russcam added a commit that referenced this issue Dec 15, 2017
@russcam
Add phrase_limit to highlighting
8adfa8a 
- Change order from string to HighlighterOrder?
- Change TagsSchema from string to HighlighterTagsSchema?
- Remove BoundaryMaxSize
- Change Encoder to HighlighterEncoder?
- Remove encoder from highlight fields as it is only valid on the top level highlighter
- Add Encoder and PhraseLimit to integration test

Closes #2851
@russcam russcam mentioned this issue Dec 15, 2017
Merged
@russcam
Copy link
Contributor Author

russcam commented Dec 15, 2017

I've opened #2959 to address

russcam added a commit that referenced this issue Dec 19, 2017
@russcam
Add phrase_limit to highlighting
56d9166 
- Change order from string to HighlighterOrder?
- Change TagsSchema from string to HighlighterTagsSchema?
- Remove BoundaryMaxSize
- Change Encoder to HighlighterEncoder?
- Remove encoder from highlight fields as it is only valid on the top level highlighter
- Add Encoder and PhraseLimit to integration test

Closes #2851
russcam added a commit that referenced this issue Dec 19, 2017
@russcam
Add phrase_limit to highlighting
5632144 
- Add Encoder and PhraseLimit to integration test
- Deprecate Encoder on HighlightField

Closes #2851

(cherry picked from commit 56d9166)
russcam added a commit that referenced this issue Dec 19, 2017
@russcam
Add phrase_limit to highlighting
efbb717 
- Add Encoder and PhraseLimit to integration test
- Deprecate Encoder on HighlightField
- Add IndexOptions.Offsets to LeadDeveloper LastName to allow Postings highlighter to be used

Closes #2851

(cherry picked from commit 5632144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@russcam @bkowald