-
Notifications
You must be signed in to change notification settings - Fork 1.2k
PhraseSuggestCollate needs a Params property to pass params to the collate query #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening @tsquires; apologies it's taken a while to respond. Looking at this now |
russcam
added a commit
that referenced
this issue
Dec 18, 2017
PhraseSuggestCollate Query takes an ITemplateQuery that allows the specification of parameters. The API of phrase suggester however specifies the parameters for the query at the same level as the query, not nested within the query object. This commit adds a Parameters dictionary to IPhraseSuggestCollate so that parameters are serialized to the correct query form. If parameters are specified on the ITemplateQuery, these are assigned to the parameters on IPhraseSuggestCollate. Add XML documentation to indicate the usage of each property. Closes #2849
russcam
added a commit
that referenced
this issue
Dec 21, 2017
PhraseSuggestCollate Query takes an ITemplateQuery that allows the specification of parameters. The API of phrase suggester however specifies the parameters for the query at the same level as the query, not nested within the query object. This commit adds a Parameters dictionary to IPhraseSuggestCollate so that parameters are serialized to the correct query form. If parameters are specified on the ITemplateQuery, these are assigned to the parameters on IPhraseSuggestCollate. Add XML documentation to indicate the usage of each property. Closes #2849
russcam
added a commit
that referenced
this issue
Dec 21, 2017
This commit adds a Parameters dictionary to IPhraseSuggestCollate so that parameters are serialized to the correct query form and introduces a PhraseSuggestCollateQuery to specify the query. Add XML documentation to indicate the usage of each property. Closes #2849 (cherry-picked from commit f905270)
russcam
added a commit
that referenced
this issue
Dec 21, 2017
PhraseSuggestCollate Query takes an IScript that allows the specification of parameters. The API of phrase suggester however specifies the parameters for the query at the same level as the query, not nested within the query object. This commit adds a Parameters dictionary to IPhraseSuggestCollate so that parameters are serialized to the correct query form. If parameters are specified on the IScript, these are assigned to the parameters on IPhraseSuggestCollate. Add XML documentation to indicate the usage of each property. Closes #2849 (cherry picked from commit f905270)
russcam
added a commit
that referenced
this issue
Dec 22, 2017
* Add Params to PhraseSuggestCollate This commit adds a Parameters dictionary to IPhraseSuggestCollate so that parameters are serialized to the correct query form and introduces a PhraseSuggestCollateQuery to specify the query. Add XML documentation to indicate the usage of each property. Closes #2849 (cherry-picked from commit f905270) * Deprecate all usages of TemplateQuery Now that Phrase suggester no longer uses TemplateQuery, deprecate the interface, object initializer and fluent descriptor of template query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NEST/ElasticSearch.Net 5.3
Elasticsearch 5.5
When running a collate query on a phrase suggester the json produced and sent to the server looks like this with the params object inside of the query object:
While a working query when setting up the json manually looks like this with the params object inside of the collate object instead:
Steps to reproduce:
Adding a Params property to PhraseSuggestCollate fixes this and produces a working request.
The text was updated successfully, but these errors were encountered: