Skip to content

shard_min_doc_count parameter for Significant Terms Aggregation is not supported by NEST client #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anatoly21 opened this issue Sep 8, 2017 · 3 comments
Closed

shard_min_doc_count parameter for Significant Terms Aggregation is not supported by NEST client #2847

anatoly21 opened this issue Sep 8, 2017 · 3 comments

Comments

@anatoly21
Copy link

Nest Version 5.0.0.0
Elasticsearch version: 5.5.2

I cannot find how to specify shard_min_doc_count with NEST. Am I missing something ?
@russcam
Copy link
Contributor

russcam commented Dec 15, 2017

Hey @anatoly21, apologies for not responding to this issue sooner. This is indeed missing from the Significant Terms aggregation in NEST, currently. I'll open a PR shortly to address 👍

russcam added a commit that referenced this issue Dec 15, 2017
@russcam
Add shard_min_doc_count to Significant Terms Aggregation
8d5fb93 
Change MinimumDocumentCount to long? to align with Elasticsearch implementation

Closes #2847
@russcam russcam mentioned this issue Dec 15, 2017
Merged
@russcam
Copy link
Contributor

russcam commented Dec 15, 2017

I've opened #2958

@anatoly21
Copy link
Author

Thanks

russcam added a commit that referenced this issue Dec 18, 2017
@russcam
Add shard_min_doc_count to Significant Terms Aggregation
fdd0eb1 
Change MinimumDocumentCount to long? to align with Elasticsearch implementation

Closes #2847
russcam added a commit that referenced this issue Dec 19, 2017
@russcam
Add shard_min_doc_count to Significant Terms Aggregation
717281a 
Add MinimumDocumentCountAsLong field to align with Elasticsearch implementation and deprecate MinimumDocumentCount with ObsoleteAttribute

Closes #2847

(cherry picked from commit fdd0eb1)
russcam added a commit that referenced this issue Dec 19, 2017
@russcam
Add shard_min_doc_count to Significant Terms Aggregation
99eea29 
Add MinimumDocumentCountAsLong field to align with Elasticsearch implementation and deprecate MinimumDocumentCount with ObsoleteAttribute

Closes #2847

(cherry picked from commit fdd0eb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@russcam @anatoly21