Avoid indented formatting for IStreamSerializable

Author: stevejgordon

src/Elastic.Clients.Elasticsearch/Api/BulkRequest.cs

@@ -34,11 +34,14 @@ public void Serialize(Stream stream, IElasticsearchClientSettings settings, Seri
 		foreach (var op in Operations)
 		{
 			if (op is not IStreamSerializable serializable)
-				throw new InvalidOperationException("");
+			{
+				ThrowHelper.ThrowInvalidOperationForBulkWhenNotIStreamSerializable();
+				return;
+			}
 
 			op.PrepareIndex(index);
 
-			serializable.Serialize(stream, settings, formatting);
+			serializable.Serialize(stream, settings, SerializationFormatting.None);
 			stream.WriteByte((byte)'\n');
 		}
 	}
@@ -53,11 +56,14 @@ public async Task SerializeAsync(Stream stream, IElasticsearchClientSettings set
 		foreach (var op in Operations)
 		{
 			if (op is not IStreamSerializable serializable)
-				throw new InvalidOperationException("");
+			{
+				ThrowHelper.ThrowInvalidOperationForBulkWhenNotIStreamSerializable();
+				return;
+			}
 
 			op.PrepareIndex(index);
 
-			await serializable.SerializeAsync(stream, settings, formatting).ConfigureAwait(false);
+			await serializable.SerializeAsync(stream, settings, SerializationFormatting.None).ConfigureAwait(false);
 			stream.WriteByte((byte)'\n');
 		}
 	}
@@ -200,11 +206,14 @@ public void Serialize(Stream stream, IElasticsearchClientSettings settings, Seri
 		foreach (var op in _operations)
 		{
 			if (op is not IStreamSerializable serializable)
-				throw new InvalidOperationException("");
+			{
+				ThrowHelper.ThrowInvalidOperationForBulkWhenNotIStreamSerializable();
+				return;
+			}
 
 			op.PrepareIndex(index);
 
-			serializable.Serialize(stream, settings, formatting);
+			serializable.Serialize(stream, settings, SerializationFormatting.None);
 			stream.WriteByte((byte)'\n');
 		}
 	}
@@ -219,11 +228,14 @@ public async Task SerializeAsync(Stream stream, IElasticsearchClientSettings set
 		foreach (var op in _operations)
 		{
 			if (op is not IStreamSerializable serializable)
-				throw new InvalidOperationException("");
+			{
+				ThrowHelper.ThrowInvalidOperationForBulkWhenNotIStreamSerializable();
+				return;
+			}
 
 			op.PrepareIndex(index);
 
-			await serializable.SerializeAsync(stream, settings, formatting).ConfigureAwait(false);
+			await serializable.SerializeAsync(stream, settings, SerializationFormatting.None).ConfigureAwait(false);
 			stream.WriteByte((byte)'\n');
 		}
 	}

src/Elastic.Clients.Elasticsearch/Core/Exceptions/ThrowHelper.cs

@@ -28,4 +28,7 @@ internal static void ThrowInvalidOperationException(string message) =>
 
 	[MethodImpl(MethodImplOptions.NoInlining)]
 	internal static void ThrowJsonExceptionForMissingSettings() => throw new JsonException("Unable to retrieve client settings for JsonSerializerOptions.");
+
+	[MethodImpl(MethodImplOptions.NoInlining)]
+	internal static void ThrowInvalidOperationForBulkWhenNotIStreamSerializable() => throw new InvalidOperationException("Operation must implement IStreamSerializable.");
 }

src/Elastic.Clients.Elasticsearch/Serialization/DefaultRequestResponseSerializer.cs

@@ -60,7 +60,7 @@ public override void Serialize<T>(T data, Stream writableStream,
 	{
 		if (data is IStreamSerializable streamSerializable)
 		{
-			streamSerializable.Serialize(writableStream, _settings, formatting);
+			streamSerializable.Serialize(writableStream, _settings, SerializationFormatting.None);
 			return;
 		}
 
@@ -73,7 +73,7 @@ public override Task SerializeAsync<T>(T data, Stream stream,
 	{
 		if (data is IStreamSerializable streamSerializable)
 		{
-			return streamSerializable.SerializeAsync(stream, _settings, formatting);
+			return streamSerializable.SerializeAsync(stream, _settings, SerializationFormatting.None);
 		}
 
 		return base.SerializeAsync(data, stream, formatting, cancellationToken);

src/Elastic.Clients.Elasticsearch/Serialization/IStreamSerializable.cs

@@ -9,7 +9,7 @@
 namespace Elastic.Clients.Elasticsearch.Serialization;
 
 /// <summary>
-/// Used to mark types which expect to directly serialise into a stream. This supports non-json compliant output such as NDJSON.
+/// Used to mark types which expect to directly serialize into a stream. This supports non-json compliant output such as NDJSON.
 /// </summary>
 internal interface IStreamSerializable
 {

src/Elastic.Clients.Elasticsearch/Types/Core/Bulk/BulkOperationsCollection.cs

@@ -235,9 +235,12 @@ public void Serialize(Stream stream, IElasticsearchClientSettings settings, Seri
 		foreach (var op in this)
 		{
 			if (op is not IStreamSerializable serializable)
-				throw new InvalidOperationException("");
+			{
+				ThrowHelper.ThrowInvalidOperationForBulkWhenNotIStreamSerializable();
+				return;
+			}
 
-			serializable.Serialize(stream, settings, formatting);
+			serializable.Serialize(stream, settings, SerializationFormatting.None);
 			stream.WriteByte((byte)'\n');
 		}
 	}
@@ -247,9 +250,12 @@ public async Task SerializeAsync(Stream stream, IElasticsearchClientSettings set
 		foreach (var op in this)
 		{
 			if (op is not IStreamSerializable serializable)
-				throw new InvalidOperationException("");
+			{
+				ThrowHelper.ThrowInvalidOperationForBulkWhenNotIStreamSerializable();
+				return;
+			}
 
-			await serializable.SerializeAsync(stream, settings, formatting).ConfigureAwait(false);
+			await serializable.SerializeAsync(stream, settings, SerializationFormatting.None).ConfigureAwait(false);
 			stream.WriteByte((byte)'\n');
 		}
 	}