Fixes for serialization after refactoring

Author: stevejgordon

src/Elastic.Clients.Elasticsearch/Core/Infer/IndexName/IndexName.cs

@@ -4,13 +4,15 @@
 
 using System;
 using System.Diagnostics;
+using System.Text.Json.Serialization;
 using Elastic.Transport;
 
 namespace Elastic.Clients.Elasticsearch;
 
 /// <summary>
 /// Represents the name of an index, which may be inferred from a <see cref="Type"/>.
 /// </summary>
+[JsonConverter(typeof(IndexNameConverter))]
 [DebuggerDisplay("{DebugDisplay,nq}")]
 public class IndexName : IEquatable<IndexName>, IUrlParameter
 {
@@ -48,7 +50,7 @@ private IndexName(string index, Type type, string cluster = null)
 	string IUrlParameter.GetString(ITransportConfiguration settings)
 	{
 		if (settings is not IElasticsearchClientSettings elasticsearchClientSettings)
-			throw new Exception("Tried to pass index name on querystring but it could not be resolved because no Elastic.Clients.Elasticsearch settings are available.");
+			throw new Exception("Tried to pass index name on query string but it could not be resolved because no Elastic.Clients.Elasticsearch settings are available.");
 
 		return elasticsearchClientSettings.Inferrer.IndexName(this);
 	}

src/Elastic.Clients.Elasticsearch/Core/Infer/IndexName/IndexNameConverter.cs

@@ -13,7 +13,7 @@ namespace Elastic.Clients.Elasticsearch;
 /// <summary>
 /// Converts an <see cref="IndexName"/> to and from its JSON representation.
 /// </summary>
-internal class IndexNameConverter : JsonConverter<IndexName?>
+internal class IndexNameConverter : JsonConverter<IndexName>
 {
 	private IElasticsearchClientSettings _settings;
 

src/Elastic.Clients.Elasticsearch/Core/Infer/JoinFieldRouting/RoutingConverter.cs

@@ -28,6 +28,8 @@ public override void Write(Utf8JsonWriter writer, Routing value, JsonSerializerO
 
 		if (value.Document is not null)
 		{
+			InitializeSettings(options);
+
 			var documentId = _settings.Inferrer.Routing(value.Document.GetType(), value.Document);
 
 			if (documentId is null)

src/Elastic.Clients.Elasticsearch/Serialization/DefaultRequestResponseSerializer.cs

@@ -33,6 +33,7 @@ public DefaultRequestResponseSerializer(IElasticsearchClientSettings settings)
 					new SelfSerializableConverterFactory(settings),
 					new SelfDeserializableConverterFactory(settings),
 					new SelfTwoWaySerializableConverterFactory(settings),
+					new FieldValuesConverter(), // explicitly registered before IsADictionaryConverterFactory as we want this specialised converter to match
 					new IsADictionaryConverterFactory(),
 					new ResponseItemConverterFactory(),
 					new DictionaryResponseConverterFactory(settings),
@@ -44,6 +45,13 @@ public DefaultRequestResponseSerializer(IElasticsearchClientSettings settings)
 
 		ElasticsearchClient.SettingsTable.Add(Options, settings);
 
+		IndentedOptions = new JsonSerializerOptions(Options)
+		{
+			WriteIndented = true
+		};
+
+		ElasticsearchClient.SettingsTable.Add(IndentedOptions, settings);
+
 		_settings = settings;
 	}