Update proc to 0.9.0 #68

Mpdreamz · 2024-12-02T14:20:42Z

No description provided.

… [-E setting=value]

stevejgordon

One nit, but otherwise it looks good. The title of the PR is 0.9.0, but this uses 0.9.1.

stevejgordon · 2024-12-04T06:49:13Z

build/scripts/Targets.fs

@@ -38,6 +37,9 @@ let private clean (arguments:ParseResults<Arguments>) =

 let private build (arguments:ParseResults<Arguments>) = exec "dotnet" ["build"; "-c"; "Release"] |> ignore

+//let private test (arguments:ParseResults<Arguments>) = exec "dotnet" ["test"; "-c"; "Release"; "-f"; "net6.0"] |> ignore


Can this commented line go?

stevejgordon · 2024-12-04T06:50:24Z

src/Elastic.Elasticsearch.Ephemeral/EphemeralFileSystem.cs

-				version.Artifact(Product.Elasticsearch).LocalFolderName, clusterName);
+			var artifact = version.Artifact(Product.Elasticsearch);
+			var localFolder = artifact.LocalFolderName;
+			var temp = Path.Combine(Path.GetTempPath(), SubFolder, localFolder, clusterName);
 			return Path.Combine(temp, "home");


+1 to improved readability here!

brendon1982 · 2025-04-09T13:03:42Z

Hi All,

I've recently brought this branch into our code base, to get this fix nullean/proc#19, and experienced a failure when starting a cluster with the XPack feature on.

It turned out to be an issue with how the parameters are being supplied to ExecuteBinary in EnsureSecurityUsersInDefaultRealmAreAdded to invoke the useradd cli command. They are being supplied as a single string instead of separate strings, as is being done elsewhere when using ExecuteBinary.

To get it working I updated the parameters from:

elasticsearch-net-abstractions/src/Elastic.Elasticsearch.Ephemeral/Tasks/BeforeStartNodeTasks/XPack/EnsureSecurityUsersInDefaultRealmAreAdded.cs

Line 53 in 4bdace0

    
           $"adding user {cred.Username}", $"useradd {cred.Username} -p {cred.Password} -r {cred.Role}");

To:

ExecuteBinary(cluster.ClusterConfiguration, cluster.Writer, pluginBat,
	$"adding user {cred.Username}", "useradd", cred.Username, "-p", cred.Password, "-r", cred.Role);

And it solved it issue.

Mpdreamz added 9 commits December 2, 2024 15:20

Update proc to 9.0

d822e2e

Update to latest dotnet install

b8d3c7d

remove unnecessary quoting

7484ccf

ensure we run tests on ci

cc27128

more debugging

80e74c0

Ensure settings args are passed seperately e.g [-E, setting=value] vs…

da9ae70

… [-E setting=value]

test net6.0

4987cef

skip tests for now, they run locally need to move on

af5d53f

fix ignore

4bdace0

Mpdreamz changed the title ~~Update proc to 9.0~~ Update proc to 0.9.0 Dec 3, 2024

stevejgordon approved these changes Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update proc to 0.9.0 #68

Update proc to 0.9.0 #68

Mpdreamz commented Dec 2, 2024

stevejgordon left a comment

stevejgordon Dec 4, 2024

stevejgordon Dec 4, 2024

brendon1982 commented Apr 9, 2025 •

edited

Loading

		@@ -38,6 +37,9 @@ let private clean (arguments:ParseResults<Arguments>) =

		let private build (arguments:ParseResults<Arguments>) = exec "dotnet" ["build"; "-c"; "Release"] \|> ignore

		//let private test (arguments:ParseResults<Arguments>) = exec "dotnet" ["test"; "-c"; "Release"; "-f"; "net6.0"] \|> ignore

Update proc to 0.9.0 #68

Are you sure you want to change the base?

Update proc to 0.9.0 #68

Conversation

Mpdreamz commented Dec 2, 2024

stevejgordon left a comment

Choose a reason for hiding this comment

stevejgordon Dec 4, 2024

Choose a reason for hiding this comment

stevejgordon Dec 4, 2024

Choose a reason for hiding this comment

brendon1982 commented Apr 9, 2025 • edited Loading

brendon1982 commented Apr 9, 2025 •

edited

Loading