Allow serializing aggregations without typed keys #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
added
Category: Enhancement
swallez
force-pushed
the
serialize-without-typed-keys
branch
from
c89136a to
7931fca
Compare
swallez
added a commit
that referenced
this pull request
Jun 22, 2022
Co-authored-by: Sylvain Wallez <[email protected]>
swallez
added a commit
that referenced
this pull request
Jun 22, 2022
Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Adds a feature in
JsonpMapperthat allows serializing aggregation and suggestion results using only names as keys and not typed keys (type#name), which is what the Java client needs to correctly deserialize these data structures.This is useful when the Java API client is used as a search front-end to ES and results are serialized back to application clients, who may not expect nor understand the
type#nameformat.