-
Notifications
You must be signed in to change notification settings - Fork 19
Add password for OTA upload to LittleFS #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LeisureLadi
wants to merge
6
commits into
earlephilhower:master
Choose a base branch
from
LeisureLadi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
81719a2
Add files via upload
LeisureLadi 58917c5
Added password dialog box
LeisureLadi 02a5a92
Password Dialog Box added
LeisureLadi 4d8a2ae
Windows Batch File to compile ESP8266LittleFS.java
LeisureLadi 677e33f
Added Password Dialog Box
LeisureLadi 65d28b2
Added Password Dialog Box
LeisureLadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
ECHO off | ||
|
||
REM set pde_path=C:/temp/JavaTrials/Arduino-master/build/windows/work/lib/pde.jar | ||
REM set pde_path=C:/temp/JavaTrials/Arduino-master/app/pde.jar | ||
set pde_path=D:/Program Files (x86)/Arduino/lib/pde.jar | ||
|
||
REM set core_path=C:/temp/JavaTrials/Arduino-master/build/windows/work/lib/arduino-core.jar | ||
REM set core_path=C:/temp/JavaTrials/Arduino-master/arduino-core/arduino-core.jar | ||
set core_path=D:/Program Files (x86)/Arduino/lib/arduino-core.jar | ||
REM set lib_path=C:/temp/JavaTrials/Arduino-master/build/windows/work/lib/commons-codec-1.7.jar | ||
REM set lib_path=C:/temp/JavaTrials/Arduino-master/app/lib/commons-codec-1.7.jar | ||
REM set lib_path=C:/temp/JavaTrials/Arduino-master/arduino-core/lib/commons-codec-1.7.jar | ||
set lib_path=D:/Program Files (x86)/Arduino/lib/commons-codec-1.7.jar | ||
|
||
echo pde_path: %pde_path% | ||
echo core_path: %core_path% | ||
echo lib_path: %lib_path% | ||
|
||
mkdir bin | ||
|
||
ECHO on | ||
javac -target 1.8 -source 1.8 -cp "%pde_path%;%core_path%;%lib_path%" -d bin src/ESP8266LittleFS.java | ||
ECHO off | ||
|
||
mkdir tools | ||
mkdir tools\ESP8266LittleFS | ||
mkdir tools\ESP8266LittleFS\tool | ||
erase tools\ESP8266LittleFS\tool\esp8266littlefs.jar | ||
|
||
cd bin | ||
|
||
jar cfveM ..\tools\ESP8266LittleFS\tool\esp8266littlefs.jar -C com\esp8266\mklittlefs ESP8266LittleFS.class ESP8266LittleFS$1.class ESP8266LittleFS$2.class | ||
|
||
cd .. | ||
|
||
exit /B | ||
|
||
REM popd | ||
|
||
REM dist=$PWD/dist | ||
REM rev=$(git describe --tags) | ||
REM mkdir -p $dist | ||
REM pushd $INSTALLDIR/tools | ||
REM rm -f $dist/*.zip | ||
REM zip -r $dist/ESP8266LittleFS-$rev.zip ESP8266LittleFS/ | ||
REM popd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think you could actually see if an AUTH is needed before presenting the box? I understand that you're using it, but since ArduinoOTA is so insecure anyway I have a feeling that most people will not be using a password at all.
It's possible to probe the board using UDP comms (connect to ESP8266, send SPIFFS command, check for AUTH response, see espota.py), or even just call espota.py once, and if it fails then prompt for a PWD and try again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and simple, BTW! Just trying to make the default case the easiest/simplest for end users.