stylecheck: don't flag mismatching receiver names in generated code

Updates gh-389

Author: dominikh

stylecheck/analysis.go

@@ -50,7 +50,7 @@ var Analyzers = lintutil.InitializeAnalyzers(Docs, map[string]*analysis.Analyzer
 	},
 	"ST1016": {
 		Run:      CheckReceiverNamesIdentical,
-		Requires: []*analysis.Analyzer{buildssa.Analyzer},
+		Requires: []*analysis.Analyzer{buildssa.Analyzer, facts.Generated},
 	},
 	"ST1017": {
 		Run:      CheckYodaConditions,

stylecheck/lint.go

@@ -287,6 +287,10 @@ func CheckReceiverNamesIdentical(pass *analysis.Pass) (interface{}, error) {
 			for _, sel := range ms {
 				fn := sel.Obj().(*types.Func)
 				recv := fn.Type().(*types.Signature).Recv()
+				if IsGenerated(pass, recv.Pos()) {
+					// Don't concern ourselves with methods in generated code
+					continue
+				}
 				if Dereference(recv.Type()) != T.Type() {
 					// skip embedded methods
 					continue

stylecheck/testdata/src/CheckReceiverNamesIdentical/CheckReceiverNames.go

@@ -9,3 +9,8 @@ func (x T1) Fn3()    {}
 func (T1) Fn4()      {}
 func (_ T1) Fn5()    {}
 func (self T1) Fn6() {}
+
+func (bar T3) Fn2()  {} // want `1x "bar", 1x "meow"`
+func (meow T3) Fn3() {}
+
+func (bar T4) Fn2() {}