stylecheck: sort receiver names for reproducible output

dominikh · dominikh · commit 46b0e0c09b14 · 2019-07-26T13:59:15.000+02:00
diff --git a/stylecheck/lint.go b/stylecheck/lint.go
@@ -6,6 +6,7 @@ import (
 	"go/constant"
 	"go/token"
 	"go/types"
+	"sort"
 	"strconv"
 	"strings"
 	"unicode"
@@ -304,6 +305,7 @@ func CheckReceiverNamesIdentical(pass *analysis.Pass) (interface{}, error) {
 			for name, count := range names {
 				seen = append(seen, fmt.Sprintf("%dx %q", count, name))
 			}
+			sort.Strings(seen)
 
 			pass.Reportf(firstFn.Pos(), "methods on the same type should have the same receiver name (seen %s)", strings.Join(seen, ", "))
 		}

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ import (`
`6`	`6`	`"go/constant"`
`7`	`7`	`"go/token"`
`8`	`8`	`"go/types"`
	`9`	`+ "sort"`
`9`	`10`	`"strconv"`
`10`	`11`	`"strings"`
`11`	`12`	`"unicode"`
`@@ -304,6 +305,7 @@ func CheckReceiverNamesIdentical(pass *analysis.Pass) (interface{}, error) {`
`304`	`305`	`for name, count := range names {`
`305`	`306`	`seen = append(seen, fmt.Sprintf("%dx %q", count, name))`
`306`	`307`	`}`
	`308`	`+ sort.Strings(seen)`
`307`	`309`
`308`	`310`	`pass.Reportf(firstFn.Pos(), "methods on the same type should have the same receiver name (seen %s)", strings.Join(seen, ", "))`
`309`	`311`	`}`