Resolve imports without extension #569
Conversation
Avoid exception when no comment was attached.
| @@ -28,7 +28,8 @@ function walkExported(ast, data, addComment) { | |||
|
|
|||
| function getComments(data, path) { | |||
| if (!hasJSDocComment(path)) { | |||
| return [addBlankComment(data, path, path.node)]; | |||
| var added = addBlankComment(data, path, path.node); | |||
| return added ? [added] : []; | |||
There was a problem hiding this comment.
This avoids running into a NPE later on when addBlankComment does not return a value.
| context.code = data.source.substring | ||
| .apply(data.source, path.parentPath.node.range); | ||
| var parentNode = path.parentPath.node; | ||
| if (parentNode.range) { |
There was a problem hiding this comment.
I'm not sure when Babel dropped range but it might be possible to remove this branch entirely and just use start and end directly.
There was a problem hiding this comment.
We updated our babel deps pretty recently. I think we should be able to remove this.
| function getCachedData(dataCache, filePath) { | ||
| var path = filePath; | ||
| if (!nodePath.extname(path)) { | ||
| path = require.resolve(path); |
There was a problem hiding this comment.
I think this makes sense. A lot of people use node's resolve mechanism today.
| context.code = data.source.substring | ||
| .apply(data.source, path.parentPath.node.range); | ||
| var parentNode = path.parentPath.node; | ||
| if (parentNode.range) { |
There was a problem hiding this comment.
We updated our babel deps pretty recently. I think we should be able to remove this.
|
@arv I've added test coverage and removed the fallback for the old Babel API. |
In my use case, I have a project where imports are written without a file extension, i.e.
This PR uses
require.resolveto figure out the actual file name if no extension was specified.Most probably, a more advanced resolution would be better but this should be good enough and avoids some confusion.
Additionally, I have fixed a few problems I ran into.