Pick up name and parameters from exported functions #435
Conversation
This makes sure that we get the name and params from exported functions/classes/vars. For export default the name is inferred from the file name. Towards documentationjs#424
| function f(x) {} | ||
| }).params, [{lineNumber: 3, name: 'x', title: 'param'}]); | ||
|
|
||
| t.deepEqual(evaluate(` |
There was a problem hiding this comment.
I wasn't sure if you allowed template literals? If not I can change this to a string literal as needed.
|
Looks amazing! Thanks for helping with this. Re: template strings - documentation.js is ES5 so far and this would be the first bit of ES6ish. Checking the charts, Node 4 and above support template strings, which is quite a few, but given that this is the first change that'd up the version and there's an existing ES5 pattern, can we use the existing pattern? It's the toComment method which uses .toString on a function - or if all of these are only a few lines, line concatenation would also work. |
|
I'll change to a string. I cannot use the function toString trick as used by toComment since export is only valid syntax at the top level. |
|
Done. PTAL. |
This makes sure that we get the name and params from exported
functions/classes/vars.
For export default the name is inferred from the file name.
Towards #424