Remove unmaintained dependency: disparity #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency disparity has not been updated for 4 years and is using a very old version of the diff package which has a security alert. This alert is not relevant to the current usage of the package, however it does generate noise when installing. Additionally, it seems unwise to be relying on unmaintained packages. This commit replaces disparity with diff and adds some code to color the output which is based on disparity's logic.
tmcw
reviewed
Jul 16, 2019
src/commands/readme.js
Outdated
| const diffHeader = diffLines | ||
| .slice(0, 2) | ||
| .join('') | ||
| .replace(/[^\n\r]+/g, `${ansi.yellow.open}$&${ansi.yellow.close}`); |
There was a problem hiding this comment.
Could we use the pre-existing chalk dependency for this styling instead of introducing ansi-styles?
There was a problem hiding this comment.
Good call. My original intention was to keep the logic as close to disparity as possible but using chalk makes much more sense.
|
Thanks! |
robseaman
added a commit
to precor/web-api-bridge
that referenced
this pull request
Aug 15, 2019
…ity package This was reported to documentation with documentationjs/documentation#1257 and resolved with the merge documentationjs/documentation#1264
robseaman
added a commit
to precor/web-api-bridge
that referenced
this pull request
Aug 15, 2019
…ity package This was reported to documentation with documentationjs/documentation#1257 and resolved with the merge documentationjs/documentation#1264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency disparity has not been updated for 4 years and is using
a very old version of the diff package which has a security alert.
This alert is not relevant to the current usage of the package, however,
it does generate noise when installing. Additionally, it seems unwise to
be relying on unmaintained packages.
This commit replaces disparity with diff and adds some code to color the
output, which is based on disparity's logic.
Related issue #1257