Vuejs support #1055
Closed
Vuejs support #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Apr 20, 2018
src/index.js
Outdated
| @@ -102,8 +103,13 @@ function buildInternal(inputsAndConfig) { | |||
| if (!sourceFile.source) { | |||
| sourceFile.source = fs.readFileSync(sourceFile.file, 'utf8'); | |||
| } | |||
| var extension = sourceFile.file.substr(sourceFile.file.length - 4); | |||
|
@batje awesome! |
|
I forgot to add package-lock.json. I added it now, not sure how to update the pull request and rerun the tests. |
|
Cool! I have a few refactoring/cleanup tasks on this one that I'm pushing to #1056 |
|
I implemented your suggestion for using a const instead of a var and another suggestion from lint. |
|
@tmcw you are faster than my email. Thanks for reviewing so quickly and thoroughly. |
|
Thanks @batje - Vue support is implemented and released in 6.3.0! |
This was referenced Apr 20, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did was requested in #952 and it seems to work.
The tests fail because of an issue with chalk, but i suspect that is not my code.