Get rid of shelljs dependency #1044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A little bit of "why" behind this PR |
|
I'm happy to remove a dependency, but in terms of security - does this really change anything? If we don't use the shell.exec method, and that method isn't used in the call path of the methods that we do use, then how is there any exploit risk? |
|
Well, I think, in terms of security this particular change does not change anything. Still, to make Snyk happy (now it raises High Severity issue), I would really appreciate shelljs to be removed. And as a bonus you have minus one dependency which is only used for things that can be done with no extra complexity |
|
Rebased & merged in #1047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell.test command uses fs.existsSync & fs.statSync methods:
https://github.com/shelljs/shelljs/blob/v0.8.1/src/test.js#L62-L74
https://github.com/shelljs/shelljs/blob/v0.8.1/src/common.js#L284-L286
This PR replaces
shelljslogic with fs api methods.