Skip to content

Jaydenseric remark reference links #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2018
Merged

Conversation

tmcw
Copy link
Member

@tmcw tmcw commented Mar 1, 2018

  • fix broken normalize() utility in test suite so that it produces
    output that doesn't choke referenceLinks.
  • add DocumentationConfig option --noReferenceLinks which will be
    internal only, and turns off reference links for readme mode
  • rebuilds test output with these changes

unrelated but minor

  • includes .prettierrc and updates calls to prettier to use that instead
    of CLI options

jaydenseric and others added 4 commits February 28, 2018 13:26
Fixes #948.

This approach might be problematic when inserting markdown under a readme heading if the readme already has link references with conflicting ID’s.
- fix broken normalize() utility in test suite so that it produces
  output that doesn't choke referenceLinks.
- add DocumentationConfig option `--noReferenceLinks` which will be
  **internal only**, and turns off reference links for `readme` mode
- rebuilds test output with these changes

unrelated but minor

- includes .prettierrc and updates calls to prettier to use that instead
  of CLI options
@coveralls
Copy link

coveralls commented Mar 1, 2018

Coverage Status

Coverage decreased (-0.02%) to 86.096% when pulling 616c659 on jaydenseric-remark-reference-links into 64f660d on master.

@tmcw tmcw merged commit ab494dd into master Mar 1, 2018
@tmcw tmcw deleted the jaydenseric-remark-reference-links branch March 1, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants