-
Notifications
You must be signed in to change notification settings - Fork 485
lib/
is outdated (still includes polyglot), so running fails
#853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
lib/
is outdated, so running failslib/
is outdated (still includes polyglot), so running fails
Ah, thanks for the report, publishing a 5.0.1 with a fix now. I think in terms of release strategy, I definitely at least need to add |
That was literally a breaking change 😀 |
Thank you! |
Reopening to associate with prepublish step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using documentation (from CLI, but I assume the API as well) fails on 5.0.0 because
get-comments
is not installed. That was an explicit dependency that was removed when polyglot was removed. It seems that the published version doesn't have a freshly buildlib/
directory, which means the polyglot stuff is still there. To reproduce:npm init -y && npm i documentation && ls node_modules/documentation/parsers
you'll seepolyglot
still there, requiringget-comments
.A
preversion
(if you usenpm version
) orprepublishOnly
script could handle automatically in the future.The text was updated successfully, but these errors were encountered: