Skip to content

GitHub does not generate correctly on Windows #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
khrome83 opened this issue Dec 17, 2015 · 3 comments
Closed

GitHub does not generate correctly on Windows #318

khrome83 opened this issue Dec 17, 2015 · 3 comments

Comments

@khrome83
Copy link

When running the command with -g /-github, the URL generated points to GitHub and the local file system.

[c:\Users\zanem\Documents\GitHub\impressjs\lib\index.js:22-29](https://github.com/khrome83/impressjs/blob/2b11747318c5f74b1da21d405cdf8d6b418ac977/c:\Users\zanem\Documents\GitHub\impressjs\lib\index.js#L22-L29 "Source code on GitHub")

Expected to see -

[\lib\index.js:22-29](https://github.com/khrome83/impressjs/blob/2b11747318c5f74b1da21d405cdf8d6b418ac977/lib/index.js#L22-L29 "Source code on GitHub")

Notice that the local file system was injected each time.

Command was run on Windows 10, with Powershell (cmder) and node 5.2.

@tmcw
Copy link
Member

tmcw commented Feb 15, 2016

First step here is #338 - since I don't use Windows or have a Windows testing computer outside of 9-5 hours, we'll need Windows CI tests to start supporting the platform.

@kripod
Copy link
Contributor

kripod commented Jun 1, 2016

Please fix this, because it would be great to see git docs support on Windows. The current result looks like:

git-support

The links marked above point to the following places:

I guess that the issue is about parsing \s. While UNIX-based file systems use / in file mappings, Windows prefers \ instead.

@tmcw
Copy link
Member

tmcw commented Jun 1, 2016

Hi Kristóf,

Sorry, as I noted before, given that I have limited time for this project and I don't use a windows computer or have a go-to testing situation for Windows, this is not something I can reasonably take on. But it's be a great thing for someone who works with Windows, like yourself, to adopt and contribute to the project! I'd happily accept pull requests improving Windows support.

  • Tom

@tmcw tmcw closed this as completed in 81ff705 Jun 2, 2016
tmcw added a commit that referenced this issue Jun 2, 2016
Fixed GitHub link generation on Windows (resolves #318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants