-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat: search ignore diacritical marks #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
2975d8c
d23285e
2102b69
22d780c
803e6b6
6d0a1bf
115f0e4
91f8d79
9668613
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,4 +105,23 @@ describe('Search Plugin Tests', function() { | |
await page.fill('input[type=search]', 'test'); | ||
await expect(page).toEqualText('.results-panel h2', 'Test Page'); | ||
}); | ||
|
||
test('search ignore diacritical marks', async () => { | ||
const docsifyInitConfig = { | ||
markdown: { | ||
homepage: ` | ||
# Qué es | ||
|
||
docsify genera su sitio web de documentación sobre la marcha. A diferencia de GitBook, no genera archivos estáticos html. En cambio, carga y analiza de forma inteligente sus archivos de Markdown y los muestra como sitio web. Todo lo que necesita hacer es crear un index.html para comenzar y desplegarlo en GitHub Pages. | ||
`, | ||
}, | ||
scriptURLs: ['/lib/plugins/search.min.js'], | ||
}; | ||
await docsifyInit(docsifyInitConfig); | ||
await page.fill('input[type=search]', 'documentacion'); | ||
await expect(page).toEqualText('.results-panel h2', 'Que es'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it possible to show the accent in the result ? sorry if I missed any previous discussion regarding this. LMK There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have a good idea how to do it... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like @sy-records got 2 of the 3 I listed. Perhaps we should open a new issue regarding missing diacritical marks in the search results so we can merge and release this PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. #1491 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created a new issue for missing diacritical remarks in search results (#1492). |
||
await page.click('.clear-button'); | ||
await page.fill('input[type=search]', 'estáticos'); | ||
await expect(page).toEqualText('.results-panel h2', 'Que es'); | ||
}); | ||
}); |
Uh oh!
There was an error while loading. Please reload this page.