-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix: Cannot serve off /.../index.html
#1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jhildenbiddle
merged 12 commits into
docsifyjs:develop
from
rgladwell:fix-base-path-file-not-folder
Feb 7, 2021
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
939e23b
Fix: Cannot serve off `/.../index.html`
rgladwell 36705c7
Add end-to-end test for index file hosting
rgladwell e42c3df
Add code comments for explicit file changes
rgladwell d538c92
Add additional tests for index file hosting
rgladwell 1868d58
Add additional tests for index file hosting
rgladwell 8aee029
[wip] Attempt to switch tests to Jest
rgladwell f3362ee
Merge branch 'develop' into fix-base-path-file-not-folder
rgladwell f39e07c
Add e2e test for new Jest test framework
rgladwell 5e4c790
Verify sidebar links use file hosting
rgladwell ac5ed77
Fix: endsWith() not supported for IE11
rgladwell 831527f
Refactor: utility method moved to utility file
rgladwell d94d259
Fix IE11 error from use of String.includes()
jhildenbiddle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
const docsifyInit = require('../helpers/docsify-init'); | ||
|
||
describe(`Index file hosting`, function() { | ||
const sharedOptions = { | ||
config: { | ||
basePath: `${TEST_HOST}/docs/index.html#/`, | ||
}, | ||
testURL: `${TEST_HOST}/docs/index.html#/`, | ||
}; | ||
|
||
test('should serve from index file', async () => { | ||
await docsifyInit(sharedOptions); | ||
|
||
await expect(page).toHaveText( | ||
'#main', | ||
'A magical documentation site generator' | ||
); | ||
expect(page.url()).toMatch(/index\.html#\/$/); | ||
}); | ||
|
||
test('should use index file links in sidebar from index file hosting', async () => { | ||
await docsifyInit(sharedOptions); | ||
|
||
await page.click('a[href="#/quickstart"]'); | ||
await expect(page).toHaveText('#main', 'Quick start'); | ||
expect(page.url()).toMatch(/index\.html#\/quickstart$/); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.