Handle ObjectDoesNotExist for related instances #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
related-does-not-exist
branch
from
55c74c4 to
a173b1c
Compare
|
PR updated to handle all invocations of |
|
Can this request be merged? Need this fix! |
|
Found also need to trap Attribute error:: This was running es 6, django2, python 3.6.1 with:: Note that the latest version of elasticsearch-dsl is 6.2.0 but this has removed DocType in init so this library currently requires <= 6.1.0 |
|
Thank you @dsanders11 and sorry for the delay again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
get_instances_from_relatedraises anRelatedObjectDoesNotExistexception it escapes instead of being consideredrelated_model = Nonelike it should. This PR fixes that.