-
Notifications
You must be signed in to change notification settings - Fork 268
[Fix #111] Adding API for filtering object while indexing #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@barseghyanartur @alexgarel Any thoughts about the code and where should we document it? any suggestion about the API or anything? |
What about in here: es_index? Seems quite logical to me. |
@barseghyanartur I was also thinking same. Lets see what @alexgarel thinks about this, as he is good at documentations. |
I think this is a good idea ! It's not that at this point documentation is in a ideal state, but better put this information somewhere and move it latter, if needed. Also put a docstring on |
We've discovered the bug described in #111 and were looking at potential fixes and work-arounds. Is this PR just waiting on documentation? |
@willbarton Yes. it is waiting for the documentation. It will be great help if anyone can write something up! |
Shall I just do this? And it could be improved later on (if needed).
|
@barseghyanartur Sure! 🚀 |
Seems like we need to merge this rathar than waiting for documentation! Added docstring though! 😅 |
This fixes #111. We need to add documentation for this. But I am not sure where to add it.
overwriting the
should_index_object
and returning a boolean value should determine which object should be index.For example, if we want to index Car only with Red
color
, we can write following