-
Notifications
You must be signed in to change notification settings - Fork 269
Adding support for Postgresql JSONField #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As could not find any reviewer, I am good to have this r+ |
@safwanrahman does it work for you out of the box now? "negotiation_status": [
{}
{}
], Only when I do:
I get: "negotiation_status": {
"2": "sadf",
"foo": "baaar"
}, |
@andreasnuesslein Oops, Sorry. I expected to have it working normally. I need to fix it before releasing new version. Are you using master branch? It is high likely that there is error code. |
@safwanrahman Yeah I tried it with master but the same thing happens with the current stable pip release 7.1.0 , after setting |
mentioning #36 here for bidirectional link |
This reverts commit dc3d89f.
So I dove into the code and figured out you should just replace |
@andreasnuesslein I'm having a similar issue. Where did you replace |
hey @oehrlein , I think it was somewhere here: https://github.com/django-es/django-elasticsearch-dsl/blob/master/django_elasticsearch_dsl/documents.py#L27 but since then the code has been changed a bit it seems - sorry 🤷 I'm not involved in this anymore; @safwanrahman will probably know an answer. |
@andreasnuesslein Got it, no problem! I was just curious since I was working on (and found) a solution to the "list of empty dicts" issue you had above. |
No description provided.