Add and use CProverString.ofCharArray #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainbrenguier
force-pushed
the
romain/string-of-char-array
branch
from
f42ccdf to
dda318a
Compare
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Aug 9, 2018
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Aug 10, 2018
peterschrammel
approved these changes
Aug 10, 2018
| * | ||
| * @diffblue.noSupport | ||
| * @diffblue.fullSupport | ||
| * @diffblue.untested |
There was a problem hiding this comment.
How is this going to be tested?
There was a problem hiding this comment.
It's tested by this PR diffblue/cbmc#2374 but maybe we should have more tests in the models library.
allredj
approved these changes
Aug 10, 2018
| @@ -216,11 +237,11 @@ public String(char value[]) { | |||
| * characters outside the bounds of the {@code value} array | |||
| * | |||
| * @diffblue.limitedSupport | |||
There was a problem hiding this comment.
The reasons are detailed below: count limited by unwind, and value cannot be null.
| * Converts an array of characters to a string. This uses a loop and | ||
| * therefore in test-generation the {@code count} will be limited by the | ||
| * unwind parameter. | ||
| * This assumes {@code value} is not null, its length is greater or equal to |
There was a problem hiding this comment.
This assumes is a bit ambiguous. It looks like a precondition to the function. Maybe This constrains {@code value} to be not null...?
| * | ||
| * @param value Array of characters which is the source to copy from | ||
| * @param offset Index in {@code value} of the first character to copy | ||
| * @param count Number of characters to copy |
There was a problem hiding this comment.
We don't usually start the parameter description with an upper-case char.
There was a problem hiding this comment.
Hm. True, lower case seems standard in javadoc.
| * therefore in test-generation the {@code count} will be limited by the | ||
| * unwind parameter. | ||
| * This assumes {@code value} is not null, its length is greater or equal to | ||
| * {@code offset + count} and {@code offset} and {@code count} are positive. |
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Aug 28, 2018
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Aug 29, 2018
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Sep 5, 2018
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Sep 10, 2018
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Sep 11, 2018
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Oct 2, 2018
romainbrenguier
force-pushed
the
romain/string-of-char-array
branch
from
dda318a to
598f37f
Compare
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Oct 3, 2018
peterschrammel
approved these changes
Oct 9, 2018
| * | ||
| * @param value Array of characters which is the source to copy from | ||
| * @param offset Index in {@code value} of the first character to copy | ||
| * @param count Number of characters to copy |
There was a problem hiding this comment.
Hm. True, lower case seems standard in javadoc.
| * @return The created String | ||
| */ | ||
| public static String ofCharArray(char value[], int offset, int count) { | ||
| org.cprover.CProver.assume(value != null); |
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Oct 16, 2018
romainbrenguier
force-pushed
the
romain/string-of-char-array
branch
from
598f37f to
da73286
Compare
This adds a function for converting char arrays to strings and use it for a String constructor.
romainbrenguier
force-pushed
the
romain/string-of-char-array
branch
from
da73286 to
b7ca9fd
Compare
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
Oct 17, 2018
xbauch
pushed a commit
to xbauch/cbmc
that referenced
this pull request
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function for converting char arrays to strings and use it
for a String constructor.