Skip to content

Update/cbmc submodule may 2020 #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martin-cs
Copy link
Collaborator

No description provided.

@martin-cs
Copy link
Collaborator Author

This updates to the last working CBMC version. diffblue/cbmc#5210 breaks some of the gnat2goto regression tests. If @xbauch has a moment, an opinion on how to fix it would be most appreciated.

@chrisr-diffblue
Copy link
Contributor

@martin-cs Petr left Diffblue at the end of Feb I think, so I'm not sure if he is likely to have time/interest in working on CBMC/gnat2goto anymore.

Copy link
Collaborator

@tjj2017 tjj2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can certainly see that the cvmc submodule has been updated.
I haven't tried to review all of the individual changes in cbmc.

Copy link
Collaborator

@tjj2017 tjj2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cbmc submodule has certainly been updated.
I have not reviewed the individual cbmc changes.

@martin-cs
Copy link
Collaborator Author

@chrisr-diffblue : thanks. I was going to @ the reviewers of the diffblue/cbmc#5210 but then I noticed I reviewed that so I really should be able to figure it out.
Would it be possible to add @tjj2017 as an approved reviewer?

@xbauch : apologies.

@chrisr-diffblue
Copy link
Contributor

@martin-cs I'll look into getting Trevor added as an approved reviewer. I'm not 100% sure I have full authority to do so, but I'll check.

@chrisr-diffblue
Copy link
Contributor

@martin-cs @tjj2017 I don't have appropriate permissions to add Trevor as a collaborator, but Peter Schrammel should have just sent Trevor an invite - as soon as Trevor accepts the invite he should be an approved reviewer.

@martin-cs
Copy link
Collaborator Author

Thanks for the prompt and positive response.

@martin-cs martin-cs force-pushed the update/cbmc-submodule-may-2020 branch from c044519 to 25032ad Compare June 1, 2020 18:00
@martin-cs martin-cs merged commit 65dfae3 into diffblue:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants