-
Notifications
You must be signed in to change notification settings - Fork 12
Feature cbmc bump #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature cbmc bump #235
Conversation
@@ -164,6 +191,75 @@ package body Driver is | |||
Append_Op (Start_Body, Initialization_Statement); | |||
end Initialize_CProver_Rounding_Mode; | |||
|
|||
procedure Initialize_CProver_Dead_Object; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these three procedures only differ in the Identifier
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty much. I can abstract if if you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not insisting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - but could you make sure that @martin-cs is OK with bumping CBMC before you merge - he has some work built on top of the CBMC submodule so we'll need to make sure he's OK to rebase before we merge this gnat2goto CBMC submodule bump
I've confirmed with @martin-cs that it's ok to bump the submodule - so just needs CI sorting and second review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
BTW - If there is a specific reason for the submodule bump, (e.g. to pickup a fix/feature we need) it would be fantastic if that reason was included in the commit message for the commit that actually moves the submodule pointer :-) |
This gives us symbol table linking support in CBMC, so we should be able to do more complicated test scenarios now.
97e9496
to
708efba
Compare
Bump CBMC and fix issues arising from it