Modular subtype #221
Merged
Modular subtype #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-cs
reviewed
May 13, 2019
xbauch
force-pushed
the
feature/modular-subtype
branch
from
c7d6b76 to
b17b194
Compare
hannes-steffenhagen-diffblue
approved these changes
May 31, 2019
| Lower_Bound_Value : Integer; | ||
| Upper_Bound_Value : Integer; | ||
| begin | ||
|
|
There was a problem hiding this comment.
might be worth asserting that followed_mod_type is actually an unsigned or mod_type
xbauch
force-pushed
the
feature/modular-subtype
branch
from
b17b194 to
3f2f88c
Compare
bound-mod-type for non-power-two modulus and bounded-unsignedbv-type for power-two modulus.
By following the origin mod type and extracting the bounds.
regarding the new bounded types.
taken from UKNI and simplified a bit. Also includes a range check.
and so we need to extend the range checking interface to accept unsigned.
xbauch
force-pushed
the
feature/modular-subtype
branch
from
3f2f88c to
708484e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the initial support for modular subtypes. Operators for the new type are nor included in this PR.