Add support for N_Block_Statement node #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbauch
reviewed
Mar 12, 2019
| @@ -5110,7 +5124,7 @@ package body Tree_Walk is | |||
| Append_Op (Block, Do_Loop_Statement (N)); | |||
|
|
|||
| when N_Block_Statement => | |||
| Warn_Unhandled_Construct (Statement, "block"); | |||
| Append_Op (Block, Do_N_Block_Statement (N)); | |||
There was a problem hiding this comment.
Why not append do_subprogram_or_block directly?
There was a problem hiding this comment.
Interface. Wrapper. Consistent with others. If impl. changes in future, has further checks etc - then this does not change, and the (consistent) structure is in place. Also the wrapper function has space for ... comments!
sonodtt
force-pushed
the
N_Block_Statement_node_support
branch
from
9b95511 to
9900266
Compare
sonodtt
force-pushed
the
N_Block_Statement_node_support
branch
from
9900266 to
24c2bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for nested declares.
NB nested functions are not yet supported but nested declares in nested functions have been considered in this context.
Shortly to appear: a Github issue w.r. to nested functions - that in the scenario shown in the test-case of this PR, appear to work out of the box (by accessing outer scope variables directly from the symbol table). We should try a few more scenarios to fully assess support for nested functions.