Simplify the two functions that handle or and and operators #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnat2goto/driver/tree_walk.adb
Outdated
| -- -- | ||
| -- int intA = (int) A; // 1 | ||
| -- int intB = (int) B; // 1 | ||
| -- int intC = A | B // bitwise `or` or `and` |
There was a problem hiding this comment.
I'd just say bitop instead of | followed by // bitop can be bitor, bitand
and theoretically also xor and things like that.
There was a problem hiding this comment.
Also, the actual generated code looks more like (bool) ((int) A bitop (int) B)?
There was a problem hiding this comment.
Yes, indeed, I wanted to make it as simple as possible, and try to simulate the sequence of the calls happening inside the function.
xbauch
reviewed
Mar 6, 2019
NlightNFotis
force-pushed
the
simplify_operator_handling
branch
from
fe81ccb to
58d8907
Compare
And provide some documentation for them.
NlightNFotis
force-pushed
the
simplify_operator_handling
branch
from
58d8907 to
4ca60b7
Compare
hannes-steffenhagen-diffblue
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having two very similar functions that do the same thing but differ in one line, provide one polymorphic function that calls the appropriate function through a function pointer passed to it. I think this should simplify maintenance in the future.
Also add some documentation.