Label properties before using property slicer #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
Jun 9, 2017
src/cbmc/cbmc_parse_options.cpp
Outdated
| @@ -839,6 +832,19 @@ bool cbmc_parse_optionst::process_goto_program( | |||
| // add loop ids | |||
| goto_functions.compute_loop_numbers(); | |||
|
|
|||
| // label the assertions | |||
| label_properties(goto_functions); | |||
There was a problem hiding this comment.
Shouldn't the call in line 459 thus be removed?
There was a problem hiding this comment.
I fixed this one and I added comments to explain the current behaviour regarding labelling properties.
The labelling must happen after assertions are introduced (goto_check, cover, etc), but not relabelled after using the property slicer; otherwise the argument to the "property" option would be invalid.
peterschrammel
force-pushed
the
label-properties-before-full-slice
branch
from
81e8933 to
996f944
Compare
The same property given as argument to --property had a different name when displayed with --show-properties after using --full-slice in the same invocation of goto-instrument. Property identifiers should at least be consistent w.r.t. input arguments and log file output in the same invocation of a tool. However, the consistency ends as soon as a goto binary is stored and used (where they are relabelled). This could be fixed by storing property identifiers and preventing them from being touched after loading a goto binary.
peterschrammel
force-pushed
the
label-properties-before-full-slice
branch
from
996f944 to
40983dd
Compare
tautschnig
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.