Add --print-internal-representation to goto-instrument #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag pretty-prints every instruction in the entire program. I use it to learn about CPROVER's internal representation of particular constructs, by passing in --print-internal-representation on a one-line C program. CR: https://cr.amazon.com/r/7203184/
martin-cs
reviewed
Jun 9, 2017
| @@ -1481,7 +1497,8 @@ void goto_instrument_parse_optionst::help() | |||
| " --nondet-static add nondeterministic initialization of variables with static lifetime\n" // NOLINT(*) | |||
| " --check-invariant function instruments invariant checking function\n" | |||
| " --remove-pointers converts pointer arithmetic to base+offset expressions\n" // NOLINT(*) | |||
| " --undefined-function-is-assume-false\n" | |||
| // NOLINTNEXTLINE(whitespace/line_length) | |||
There was a problem hiding this comment.
Please could you remove the line break introduced here.
There was a problem hiding this comment.
Thanks Martin. Not sure what you mean, I didn't introduce a line break, but just added two linter directives since the linter was complaining...
|
Thanks for this patch. It seems the key difference between this and --show-goto-functions is the use of pretty() for displaying the irepts. Is their a sane way that this functionality could be folded into --show-goto-functions (or maybe --show-symbol-table)? |
karkhaz
commented
Jun 15, 2017
| @@ -1481,7 +1497,8 @@ void goto_instrument_parse_optionst::help() | |||
| " --nondet-static add nondeterministic initialization of variables with static lifetime\n" // NOLINT(*) | |||
| " --check-invariant function instruments invariant checking function\n" | |||
| " --remove-pointers converts pointer arithmetic to base+offset expressions\n" // NOLINT(*) | |||
| " --undefined-function-is-assume-false\n" | |||
| // NOLINTNEXTLINE(whitespace/line_length) | |||
There was a problem hiding this comment.
Thanks Martin. Not sure what you mean, I didn't introduce a line break, but just added two linter directives since the linter was complaining...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag pretty-prints every instruction in the entire program. I use
it to learn about CPROVER's internal representation of particular
constructs, by passing in --print-internal-representation on a one-line
C program.