Make the c_types have stronger C++ types #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
May 25, 2017
src/ansi-c/ansi_c_convert_type.cpp
Outdated
| @@ -464,14 +464,14 @@ void ansi_c_convert_typet::write(typet &type) | |||
| } | |||
|
|
|||
| if(int8_cnt) | |||
| type=is_signed?signed_char_type():unsigned_char_type(); | |||
| type=is_signed?(typet)signed_char_type():(typet)unsigned_char_type(); | |||
There was a problem hiding this comment.
Use
if(is_signed)
type=signed_char_type();
else
type=unsigned_char_type();
to 1) avoid overly long lines and 2) the type casts.
src/util/c_types.cpp
Outdated
| { | ||
| typet result=signedbv_typet(config.ansi_c.int_width); | ||
| signedbv_typet result=signedbv_typet(config.ansi_c.int_width); |
There was a problem hiding this comment.
signedbv_typet result(config.ansi_c.int_width); (and several more instances of the same)
src/util/c_types.cpp
Outdated
| { | ||
| typet result; | ||
| unsignedbv_typet result; |
There was a problem hiding this comment.
RAII - merge the lines below.
Merged
tautschnig
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt is made to make the functions in c_types.h return the strongest possible C++ type