Added tests that demonstrate problems in function pointer removal #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2017 16:54
Though this example program appears to lose const-ness, since it is a primitive it is a copy so it is irrelevant.
Uninitialized entries in an array are set to zero (i.e. the struct contains zero and a null pointer). The output should still generate the possible valid if statements as it does with an array of function pointers containing null (as demonstrated in approx-const-fp-array-variable-const-fp-with-null).
tautschnig
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two test cases that currently don't work correctly when removing function pointers.
Irrelevant loss of const
If a const primitive is assigned to a non-const primitive, this is classified as a loss of const-ness which causes the FP removal to fall back to worst case behaviour. However, this is a copy so irrelevant and should be ignored.
Array of structs with null pointer
We correctly deal with an array containing FPs including a null pointer, but do not deal with it if the pointer is inside a struct. The behaviour should be consistent.