Check some assumptions about goto programs before starting an analysis #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes; that was pretty much what I was thinking. |
|
FWIW, the output of the failing tests is now worth looking at. I'd argue some actual cleanup in goto conversion is due. |
The current set of checks is certainly very incomplete, but at least provides some entry points for adding further tests.
|
I've got this on my "list of reviews required" and would love to see this moving. What is the current status? "I don't have time right now" will be the default if I don't hear from you. Perhaps that will motivate me to make the time :-) |
|
Status is: needs a time generator. It would be really important, but there are other tasks with an earlier deadline... |
|
OK; ping me if you get time before I do :-) |
7 tasks
xbauch
pushed a commit
to xbauch/cbmc
that referenced
this pull request
Oct 8, 2018
This commit follows the style of PR diffblue#918 in terms of case analysis of goto instructions. The errors are now directly send to messaget instance and source location are added. No functionality was added, just a different form.
xbauch
pushed a commit
to xbauch/cbmc
that referenced
this pull request
Oct 8, 2018
This commit follows the style of PR diffblue#918 in terms of case analysis of goto instructions. The errors are now directly send to messaget instance and source location are added. No functionality was added, just a different form.
xbauch
pushed a commit
to xbauch/cbmc
that referenced
this pull request
Oct 10, 2018
This commit follows the style of PR diffblue#918 in terms of case analysis of goto instructions. The errors are now directly send to messaget instance and source location are added. No functionality was added, just a different form.
xbauch
pushed a commit
to xbauch/cbmc
that referenced
this pull request
Oct 10, 2018
This commit follows the style of PR diffblue#918 in terms of case analysis of goto instructions. The errors are now directly send to messaget instance and source location are added. No functionality was added, just a different form.
|
Closing as this has now been implemented properly and is run with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current set of checks is certainly very incomplete, but at least provides
some entry points for adding further tests.
This is a first attempt to address #751, and mainly intended as a basis for discussion. All input and contributions very much welcome!