Refactor java object factory #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tautschnig this replaces my earlier PR, keeping the factoring but also keeping Owen's version of the nondet-boolean rewrite. @owen-jones-diffblue check if this subsumes any existing PRs? |
smowton
changed the title
|
Looks good to me, happy to approve once #823 is merged. |
peterschrammel
changed the title
|
@peterschrammel take a look at the comments here re: the object factory convergence stuff |
peterschrammel
approved these changes
May 10, 2017
|
Ready to go once rebased! |
This splits out a few elements of the nondet-init logic that downstream branches will / are likely to want to customise or use from multiple call-sites.
smowton
force-pushed
the
refactor-java-object-factory
branch
from
7cab60f to
405ce62
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors the Java object factory to:
(a) improve input declarations
(b) Refactor for clarity (replace some explicit gotos with higher-level code-ifthenelse constructs, by @owen-jones-diffblue)
(c) Split out certain parts of the nondet-init logic into individual functions, to make the diff vs. test-gen-support's version of the same code friendlier and make them more merge-compatible.
Depends on #823