Skip to content

SMT2: bvnor, bvnand are binary only; add bvxnor #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

SMT2: bvnor, bvnand are binary only; add bvxnor #8508

merged 1 commit into from
Dec 17, 2024

Conversation

kroening
Copy link
Member

The SMT-LIB2 expressions bvnor and bvnand are not multi-ary.

Furthermore, this adds the (binary) bvxnor expression.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 36.17021% with 30 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (fa299c5) to head (99376ab).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_conv.cpp 36.17% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8508      +/-   ##
===========================================
- Coverage    78.63%   78.56%   -0.07%     
===========================================
  Files         1728     1728              
  Lines       199408   199589     +181     
  Branches     18316    18293      -23     
===========================================
+ Hits        156797   156805       +8     
- Misses       42611    42784     +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig removed their assignment Nov 28, 2024
@kroening kroening enabled auto-merge November 29, 2024 15:54
The SMT-LIB2 expressions bvnor and bvnand are not multi-ary.

Furthermore, this adds the (binary) bvxnor expression.
@kroening kroening merged commit ce40fbd into develop Dec 17, 2024
36 of 41 checks passed
@kroening kroening deleted the smt-bv branch December 17, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants